New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added cog icon #1211

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@mmcc
Member

mmcc commented May 14, 2014

Added a cog icon and removed unused PNG files.

@heff heff added confirmed labels May 15, 2014

@heff

This comment has been minimized.

Show comment
Hide comment
@heff

heff May 19, 2014

Member

Since it's totally not obvious right now, I wanted to point out the CDN fonts are actually versioned separately. So what I'll end up doing here is pulling this in, uploading the new fonts to vjs.zencdn.net/f/3/ and then updating the grunt task to point to the new version.

It could be worth breaking out the font into a separate repo at some point and making it a dependency of this one. Similar to what we've done with the swf.

Member

heff commented May 19, 2014

Since it's totally not obvious right now, I wanted to point out the CDN fonts are actually versioned separately. So what I'll end up doing here is pulling this in, uploading the new fonts to vjs.zencdn.net/f/3/ and then updating the grunt task to point to the new version.

It could be worth breaking out the font into a separate repo at some point and making it a dependency of this one. Similar to what we've done with the swf.

@mmcc mmcc closed this in 6bb9228 May 19, 2014

@heff

This comment has been minimized.

Show comment
Hide comment
@heff

heff May 19, 2014

Member

Also, currently there's no automated process for uploading the fonts to s3 and updating permissions or content-type and cache-control headers, so it's a bit of a copy/paste pain.

Member

heff commented May 19, 2014

Also, currently there's no automated process for uploading the fonts to s3 and updating permissions or content-type and cache-control headers, so it's a bit of a copy/paste pain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment