New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust subtitle timing by optional offset #1212

Closed
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@bchase

bchase commented May 15, 2014

Changed per #1190.

This is subtly different than @heff's recommendation, so please let me know if I need to adjust anything here.

@heff

This comment has been minimized.

Show comment
Hide comment
@heff

heff May 15, 2014

Member

Awesome, thanks! I'd actually prefer to not make it a direct player property since it's not an official html5 api method yet and we won't be able to make it work with native captions. Could we change it to a player option, this.player_.options()['trackTimeOffset']? You should still be able to set/get it just the same.

Member

heff commented May 15, 2014

Awesome, thanks! I'd actually prefer to not make it a direct player property since it's not an official html5 api method yet and we won't be able to make it work with native captions. Could we change it to a player option, this.player_.options()['trackTimeOffset']? You should still be able to set/get it just the same.

@bchase

This comment has been minimized.

Show comment
Hide comment
@bchase

bchase May 15, 2014

Ah, right; makes sense.

How's that look?

bchase commented May 15, 2014

Ah, right; makes sense.

How's that look?

@heff

This comment has been minimized.

Show comment
Hide comment
@heff

heff May 15, 2014

Member

lgtm! I'll pull it in tomorrow.

Member

heff commented May 15, 2014

lgtm! I'll pull it in tomorrow.

@bchase

This comment has been minimized.

Show comment
Hide comment
@bchase

bchase May 15, 2014

Good deal. Thanks!

bchase commented May 15, 2014

Good deal. Thanks!

@heff heff added confirmed labels May 15, 2014

@heff heff closed this in 23ab370 May 19, 2014

@heff

This comment has been minimized.

Show comment
Hide comment
@heff

heff May 19, 2014

Member

Pulled in, thanks again!

Member

heff commented May 19, 2014

Pulled in, thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment