New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localsauce karma #1215

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@gkatsev
Member

gkatsev commented May 16, 2014

This adds an untested local ability to run tests on saucelabs.
You run it in one of two ways:

# assuming you already have a connection to saucelabs
grunt saucelabs

# if you want grunt to run sauce_connect for you and then run the task
grunt saucelabs:connect

@gkatsev gkatsev referenced this pull request May 16, 2014

Closed

Karma local sauce #1206

@heff

This comment has been minimized.

Show comment
Hide comment
@heff

heff May 19, 2014

Member

What does someone need to do to add their own auth credentials to make this work?

Member

heff commented May 19, 2014

What does someone need to do to add their own auth credentials to make this work?

@gkatsev

This comment has been minimized.

Show comment
Hide comment
@gkatsev

gkatsev May 19, 2014

Member

Ah, right. You just need to set SAUCE_USERNAME and SAUCE_ACCESS_KEY as shell variables.

Member

gkatsev commented May 19, 2014

Ah, right. You just need to set SAUCE_USERNAME and SAUCE_ACCESS_KEY as shell variables.

@heff

This comment has been minimized.

Show comment
Hide comment
@heff

heff May 19, 2014

Member

Do you think it's worth adding something to CONTRIBUTING.md that tells people how to do that?

Member

heff commented May 19, 2014

Do you think it's worth adding something to CONTRIBUTING.md that tells people how to do that?

@gkatsev

This comment has been minimized.

Show comment
Hide comment
@gkatsev

gkatsev May 19, 2014

Member

Assuming that you've been able to run this task and it works. I've yet to test it.

Also, we do need to update CONTRIBUTING.md with how to use the test task.

Member

gkatsev commented May 19, 2014

Assuming that you've been able to run this task and it works. I've yet to test it.

Also, we do need to update CONTRIBUTING.md with how to use the test task.

@heff

This comment has been minimized.

Show comment
Hide comment
@heff

heff May 19, 2014

Member

Haven't had a chance to try the creds yet, but yeah, after that updating the doc with the test task would be great.

Member

heff commented May 19, 2014

Haven't had a chance to try the creds yet, but yeah, after that updating the doc with the test task would be great.

@heff

This comment has been minimized.

Show comment
Hide comment
@heff

heff Jun 11, 2014

Member

Where did we end up on this one?

Member

heff commented Jun 11, 2014

Where did we end up on this one?

@gkatsev

This comment has been minimized.

Show comment
Hide comment
@gkatsev

gkatsev Jun 11, 2014

Member

Did you get a chance to try that out? Other than some documentation, it should be ok.

Member

gkatsev commented Jun 11, 2014

Did you get a chance to try that out? Other than some documentation, it should be ok.

@heff

This comment has been minimized.

Show comment
Hide comment
@heff

heff Jun 11, 2014

Member

Yeah, grunt saucelabs works for me. I'm not sure I'm understanding the grunt saucelabs:connect relationship. I ran it an it just seemed to hang, not running any tests. But just running saucelabs alone worked for me.

Member

heff commented Jun 11, 2014

Yeah, grunt saucelabs works for me. I'm not sure I'm understanding the grunt saucelabs:connect relationship. I ran it an it just seemed to hang, not running any tests. But just running saucelabs alone worked for me.

@gkatsev

This comment has been minimized.

Show comment
Hide comment
@gkatsev

gkatsev Jun 11, 2014

Member

Ah, grunt saucelabs worked? Cool.
I added grunt saucelabs:connect to equivalent to what is happening on travis ci with the "sauce connect" plugin thing, but it's very possible we don't actually need it for running locally.

Member

gkatsev commented Jun 11, 2014

Ah, grunt saucelabs worked? Cool.
I added grunt saucelabs:connect to equivalent to what is happening on travis ci with the "sauce connect" plugin thing, but it's very possible we don't actually need it for running locally.

@heff

This comment has been minimized.

Show comment
Hide comment
@heff

heff Jul 3, 2014

Member

Would you rather I pull this in now or wait until you can apply you latest learning?

Member

heff commented Jul 3, 2014

Would you rather I pull this in now or wait until you can apply you latest learning?

@heff heff closed this in 813f28f Jul 8, 2014

paullryan added a commit to paullryan/video.js that referenced this pull request Jul 17, 2014

@gkatsev gkatsev deleted the gkatsev:localsauce-karma branch Aug 12, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment