New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Count stageclick events from the SWF as user activity #1291

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@dmlap
Member

dmlap commented Jun 13, 2014

IE11 on Win8.1 RT does not report click events on the SWF object. The SWF already triggers stageclick events whenever a click/touch is detected however, so we can use those to keep the control bar from hiding forever.

Count stageclick events from the SWF as user activity
IE11 on Win8.1 RT does not report click events on the SWF object. The SWF already triggers stageclick events whenever a click/touch is detected however, so we can use those to keep the control bar from hiding forever.
@heff

This comment has been minimized.

Show comment
Hide comment
@heff

heff Jun 13, 2014

Member

Pulling this in. If we wanted to actually trigger a click with this as well, so toggling the video playback still worked, how complicated does it get?

Member

heff commented Jun 13, 2014

Pulling this in. If we wanted to actually trigger a click with this as well, so toggling the video playback still worked, how complicated does it get?

@heff heff closed this in 1557810 Jun 13, 2014

@dmlap

This comment has been minimized.

Show comment
Hide comment
@dmlap

dmlap Jun 16, 2014

Member

@heff: we could get close with player.on('stageclick', function() { player.trigger('click'); }). We'd want to test it out pretty thoroughly beforehand to make sure it didn't break any assumptions we're making elsewhere, however. It wouldn't be a native click event and we might see inconsistent behavior as a result. A more targeted approach might be to toggle the playback state in the stageclick handler directly.

Member

dmlap commented Jun 16, 2014

@heff: we could get close with player.on('stageclick', function() { player.trigger('click'); }). We'd want to test it out pretty thoroughly beforehand to make sure it didn't break any assumptions we're making elsewhere, however. It wouldn't be a native click event and we might see inconsistent behavior as a result. A more targeted approach might be to toggle the playback state in the stageclick handler directly.

@dmlap dmlap deleted the dmlap:hotfix/win8-stageclicks branch Jun 16, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment