New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dispose tech after turning event bindings off #1312

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@mattosborn
Contributor

mattosborn commented Jun 25, 2014

Switching the disposal order so that event bindings are turned off before tech.dispose() is called. Previously, bindings to timeupdate that touched the tech element would error out, as the element was destroyed before a timeupdate event was triggered in player.js:403

@gkatsev

This comment has been minimized.

Show comment
Hide comment
@gkatsev

gkatsev Jun 25, 2014

Member

LGTM

Member

gkatsev commented Jun 25, 2014

LGTM

@heff

This comment has been minimized.

Show comment
Hide comment
@heff

heff Jun 25, 2014

Member

Awesome, thanks! That last timeupdate is meant to help the progress bar reach the end, but I had a feeling that would cause issues elsewhere... Will pull in soon.

Member

heff commented Jun 25, 2014

Awesome, thanks! That last timeupdate is meant to help the progress bar reach the end, but I had a feeling that would cause issues elsewhere... Will pull in soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment