New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bower: ignore dot files, build and tests #1337

Merged
merged 1 commit into from Jul 28, 2014

Conversation

Projects
None yet
2 participants
@gkralik
Contributor

gkralik commented Jul 9, 2014

Add 'ignore' directive to bower.json.

This ignores all dot files, test directories and build directories. Fixes #1105.

@heff

This comment has been minimized.

Show comment
Hide comment
@heff

heff Jul 9, 2014

Member

#1337, it must be good. :) Thanks for this.

Member

heff commented Jul 9, 2014

#1337, it must be good. :) Thanks for this.

"node_modules",
"bower_components",
"test",
"tests",

This comment has been minimized.

@heff

heff Jul 9, 2014

Member

We don't have tests, node_modules, or bower_components directories in the repo. Are they needed, and if not, can you remove them?

@heff

heff Jul 9, 2014

Member

We don't have tests, node_modules, or bower_components directories in the repo. Are they needed, and if not, can you remove them?

@gkralik

This comment has been minimized.

Show comment
Hide comment
@gkralik

gkralik Jul 9, 2014

Contributor

These are just the standard ignored directories for bower packages. I could exclude them if you want, but I don't think they hurt...

Contributor

gkralik commented Jul 9, 2014

These are just the standard ignored directories for bower packages. I could exclude them if you want, but I don't think they hurt...

@heff

This comment has been minimized.

Show comment
Hide comment
@heff

heff Jul 9, 2014

Member

If that’s the case that should be fine, but could you comment here with link to a guide or example of that so we have a record of it?

Member

heff commented Jul 9, 2014

If that’s the case that should be fine, but could you comment here with link to a guide or example of that so we have a record of it?

@gkralik

This comment has been minimized.

Show comment
Hide comment
@gkralik

gkralik Jul 9, 2014

Contributor

I'll look up the reference tomorrow morning. They're the paths that are recommended when running bower init.

Contributor

gkralik commented Jul 9, 2014

I'll look up the reference tomorrow morning. They're the paths that are recommended when running bower init.

@gkralik

This comment has been minimized.

Show comment
Hide comment
@gkralik
Contributor

gkralik commented Jul 9, 2014

@heff

This comment has been minimized.

Show comment
Hide comment
@heff

heff Jul 9, 2014

Member

perfect, thanks!

Member

heff commented Jul 9, 2014

perfect, thanks!

@heff heff merged commit bdc89a0 into videojs:master Jul 28, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

heff added a commit that referenced this pull request Jul 28, 2014

@heff

This comment has been minimized.

Show comment
Hide comment
@heff

heff Jul 28, 2014

Member

Thank you!

If you're on IRC join the #videojs room to chat with other contributors.

Member

heff commented Jul 28, 2014

Thank you!

If you're on IRC join the #videojs room to chat with other contributors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment