New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #492 #1345

Merged
merged 1 commit into from Jul 28, 2014

Conversation

Projects
None yet
3 participants
@jackunion
Contributor

jackunion commented Jul 13, 2014

Binds up/down arrows for sliders

fixes #492
Binds up/down arrows for sliders

@mmcc mmcc added the enhancement label Jul 14, 2014

@heff

This comment has been minimized.

Show comment
Hide comment
@heff

heff Jul 26, 2014

Member

Awesome, thanks! Will pull in soon.

Member

heff commented Jul 26, 2014

Awesome, thanks! Will pull in soon.

@heff

This comment has been minimized.

Show comment
Hide comment
@heff

heff Jul 28, 2014

Member

The branch that this was sent from seems to have gotten deleted, but looks like github will still let me pull this in automatically at least.

Member

heff commented Jul 28, 2014

The branch that this was sent from seems to have gotten deleted, but looks like github will still let me pull this in automatically at least.

heff added a commit that referenced this pull request Jul 28, 2014

@heff heff merged commit 951370d into videojs:master Jul 28, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

heff added a commit that referenced this pull request Jul 28, 2014

@heff

This comment has been minimized.

Show comment
Hide comment
@heff

heff Jul 28, 2014

Member

Thank you!

If you're on IRC check out the #videojs room to chat with other contributors.

Member

heff commented Jul 28, 2014

Thank you!

If you're on IRC check out the #videojs room to chat with other contributors.

@jackunion

This comment has been minimized.

Show comment
Hide comment
@jackunion

jackunion Jul 29, 2014

Contributor

@heff yeah, my bad, it was an accident with the branch. Glad it didn't cause a lot of troubles :]
I'll definitely check your channel out some day, unfortunately, I'm in the begginning of, uhm, escaping from my country right now and things are a bit unsettled.

Best wishes :]

Contributor

jackunion commented Jul 29, 2014

@heff yeah, my bad, it was an accident with the branch. Glad it didn't cause a lot of troubles :]
I'll definitely check your channel out some day, unfortunately, I'm in the begginning of, uhm, escaping from my country right now and things are a bit unsettled.

Best wishes :]

@heff

This comment has been minimized.

Show comment
Hide comment
@heff

heff Jul 29, 2014

Member

Woah...good luck! That sure puts my video player problems in perspective.

Member

heff commented Jul 29, 2014

Woah...good luck! That sure puts my video player problems in perspective.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment