New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return src value from HTML5 tech #1430

Merged
merged 1 commit into from Aug 27, 2014

Conversation

Projects
None yet
2 participants
@mattosborn
Contributor

mattosborn commented Aug 19, 2014

Calling player.src() with no arguments overwrites the HTML5 src attribute with undefined instead of returning the current value.

https://github.com/guardian/video.js/blob/21f2d3c150b3573337030758f7dfb634f6798052/src/js/player.js#L1111

@heff

This comment has been minimized.

Show comment
Hide comment
@heff

heff Aug 22, 2014

Member

Hmm, yeah. That's not good. Thanks for the fix.

Member

heff commented Aug 22, 2014

Hmm, yeah. That's not good. Thanks for the fix.

@heff heff added bug labels Aug 22, 2014

@heff heff merged commit 21f2d3c into videojs:master Aug 27, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

heff added a commit that referenced this pull request Aug 27, 2014

@heff

This comment has been minimized.

Show comment
Hide comment
@heff

heff Aug 27, 2014

Member

Pulled in. Thanks Matt!

Member

heff commented Aug 27, 2014

Pulled in. Thanks Matt!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment