New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bind 'onKeyPress' during keydown instead of keyup. #1455

Merged
merged 1 commit into from Aug 27, 2014

Conversation

Projects
None yet
2 participants
@songpete
Contributor

songpete commented Aug 27, 2014

Binding during keydown will be more effective at preventing certain default behavior like moving the page down as these events may happen prior to keyup. Addresses #1452

Bind 'onKeyPress' during keydown instead of keyup.
Binding during keydown will be more effective at preventing certain default behavior like moving the page down as these events may happen prior to keyup. Addresses #1452
@heff

This comment has been minimized.

Show comment
Hide comment
@heff

heff Aug 27, 2014

Member

Very nice, thanks!

Member

heff commented Aug 27, 2014

Very nice, thanks!

@heff heff merged commit 58c081f into videojs:master Aug 27, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

heff added a commit that referenced this pull request Aug 27, 2014

@songpete songpete deleted the songpete:patch-1 branch Sep 8, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment