New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inherit tech 'features' from 'MediaTechController' #1470

Merged
merged 5 commits into from Sep 2, 2014

Conversation

Projects
None yet
2 participants
@gkatsev
Member

gkatsev commented Sep 2, 2014

Obsoletes #1412.

gkatsev added some commits Aug 11, 2014

Inherit tech 'features' from 'MediaTechController'
Use vjs.obj.create to inherit 'features' from
'MediaTechController.prototype.features'. Because we are inheriting, if
the defaults change (prototype.features), we can receive these updates
in our tech if we had not changed properties of features manually.
Update media.js and html5.js feature access.
Due to #1415, various usage of features moved around. This makes sure
that features are now called directly on the tech everywhere.

@gkatsev gkatsev changed the title from Inherit tech 'features' from 'MediaTechController to Inherit tech 'features' from 'MediaTechController' Sep 2, 2014

@heff heff merged commit 599217f into videojs:master Sep 2, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

heff added a commit that referenced this pull request Sep 2, 2014

@heff

This comment has been minimized.

Show comment
Hide comment
@heff

heff Sep 2, 2014

Member

Thanks!

Member

heff commented Sep 2, 2014

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment