Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Make sure we remove all document listeners on dispose. #1475
The document listeners are removed on the slider's mouseup event, so this would fix the case that the player is disposed of in the middle of sliding a slider. Seems unlikely but not impossible. Was there a specific use case where you saw this happen, or are you finding the listeners aren't being removed on mouseup as expected? Or is this tightening things up?
Essentially I have a rudimentary playlist which plays a video and on complete disposes the video player and creates a new one with the next video. I get a null error when seeking to the end of the video causing it to trigger the complete event and than dispose the video player.
#1476 is another example of event listeners staying alive. Disposing a video player while in full screen mode eventually causes a null exception.