From 5c2a3cbbf8db80b9ab3c1790d0199bed9ff9ffe9 Mon Sep 17 00:00:00 2001 From: sirudog Date: Sun, 18 Mar 2012 22:25:19 +0100 Subject: [PATCH 1/2] Fix bug in loop for removing source/track nodes from video element. "j.length" changed in each loop step, causing source/track nodes being left in DOM. --- src/player.js | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/player.js b/src/player.js index 2cc6f36584..59e7870387 100644 --- a/src/player.js +++ b/src/player.js @@ -58,9 +58,10 @@ _V_.Player = _V_.Component.extend({ // Empty video tag sources and tracks so the built in player doesn't use them also. if (tag.hasChildNodes()) { - for (var i=0,j=tag.childNodes;i Date: Sun, 18 Mar 2012 22:36:04 +0100 Subject: [PATCH 2/2] Fixed bug of traversing video source/track child nodes by making nodeName comparison case-insensitive. It caused the issue of flash-fallback not being able to discover the source of the video and embed it into flashvars. --- src/player.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/player.js b/src/player.js index 59e7870387..29c376c697 100644 --- a/src/player.js +++ b/src/player.js @@ -60,7 +60,7 @@ _V_.Player = _V_.Component.extend({ if (tag.hasChildNodes()) { var nrOfChildNodes = tag.childNodes.length; for (var i=0,j=tag.childNodes;i