Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a simple mistake that make native JSON.parse never been used #1565

Closed
wants to merge 1 commit into from

Conversation

aptx4869
Copy link
Contributor

@aptx4869 aptx4869 commented Oct 5, 2014

window.JSON.parse === 'function'

should be

typeof window.JSON.parse === 'function'

@gkatsev
Copy link
Member

gkatsev commented Oct 5, 2014

That's a pretty silly mistake. Thanks!

@aptx4869
Copy link
Contributor Author

aptx4869 commented Oct 5, 2014

This mistake is simple but it breaks our app...
We use a CSP that call to eval is not allowed but Javascript JSON implementation use eval...

@gkatsev
Copy link
Member

gkatsev commented Oct 5, 2014

We're hoping that in a newer version of videojs, we're just going to remove this file altogether and make a valid JSON implementation a dependency. There's a bug related to that somewhere.

@heff
Copy link
Member

heff commented Oct 6, 2014

Ha, wow. Thanks!

@heff
Copy link
Member

heff commented Oct 6, 2014

Merged in, thanks!

@aptx4869 aptx4869 deleted the fix-json-parse branch October 7, 2014 00:25
@heff heff mentioned this pull request Oct 22, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants