Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix undefined source var #1651

Closed
wants to merge 1 commit into from
Closed

fix undefined source var #1651

wants to merge 1 commit into from

Conversation

toloudis
Copy link

@toloudis toloudis commented Nov 8, 2014

It is possible that the source var is undefined and then this code still checks source.src. My fix takes care of this.

Use case: I create my video element with
var $element = $("<video>").attr("src", src);
and then later call
this.player = videojs(el, {}, function() {});
after adding it to the dom.

Fix exception when source is not provided as an option
@heff
Copy link
Member

heff commented Nov 17, 2014

Thanks for this! We'll get this pulled in and released soon.

@heff heff closed this in 33e6630 Nov 25, 2014
@heff
Copy link
Member

heff commented Nov 25, 2014

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants