Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
Don't auto-add the textTrackDisplay component. Add a 'featuresNativeTrack'. Currently hardcoded to false for everything except the html5 tech. Add textTracks and addTextTrack methods to html5 tech. Proxy player level methods to tech if we're using native tracks. Fix up track menu items to work with spec tracks or vjs tracks.
Also, if text tracks are old and use numerical mode values, use custom tracks. If an html tech is using custom tracks, remove track elements so we don't accidentally show both custom and native captions. Clean up showTextTrack slightly.
textTracks is completely inside of techs but needs to be called manually because techGet requires the tech to be ready. addTextTrack, unfortunately, currently forks. If when called, it doesn't have a tech, it assumes that it's a custom implementation and does the same work that MediaTechController#addTextTrack does. Don't create a flash getter for textTracks.
Load up textTrackDisplay synchronously but have it do no work until the player is ready (see the previous commit).
Add a check that delegates to MediaTechController's methods if we're in Html5 but we are not using native tracks.
MenuButton's new 'update' method conflicted with volumeMenuButton's update method which was used to update volume levels.
I don't think that just saying this breaks in IE8 is a good enough reason to turn it off for ie8. :-P
Why isn't it working in IE8? And if the goal is to have tracks that work everywhere, why is this test still valuable otherwise?