Normalize IE9 URL parsing. Fix for #1764 #1765

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
2 participants
@dmlap
Member

dmlap commented Dec 22, 2014

IE9 appends the port number to the host property of anchor tags on http pages. Strip the port for http and https so that it behaves like everyone else.

Normalize IE9 URL parsing. Fix for #1764
IE9 appends the port number to the host property of anchor tags on http pages. Strip the port for http and https so that it behaves like everyone else.
test/unit/lib.js
+var createElement;
+
+module('Lib', {
+ setup: function() {

This comment has been minimized.

@heff

heff Dec 22, 2014

Member

I think you need quotes around setup/teardown.

@heff

heff Dec 22, 2014

Member

I think you need quotes around setup/teardown.

@heff

This comment has been minimized.

Show comment
Hide comment
@heff

heff Dec 22, 2014

Member

Something is breaking tests. Might be the note I made.

Member

heff commented Dec 22, 2014

Something is breaking tests. Might be the note I made.

Quote methods for closure compiler
Make sure `setup` and `teardown` don't get minified so that the lib tests don't pollute the global environment.
@dmlap

This comment has been minimized.

Show comment
Hide comment
@dmlap

dmlap Dec 22, 2014

Member

@heff locally, looks like you were right about the quoting.

Member

dmlap commented Dec 22, 2014

@heff locally, looks like you were right about the quoting.

@heff

This comment has been minimized.

Show comment
Hide comment
@heff

heff Dec 22, 2014

Member

lgtm; Did you test this on a page that uses a local server with a different port?

Member

heff commented Dec 22, 2014

lgtm; Did you test this on a page that uses a local server with a different port?

@dmlap

This comment has been minimized.

Show comment
Hide comment
@dmlap

dmlap Dec 23, 2014

Member

Yes, that's how I normally do my testing. Getting things setup so I could test on port 80 ended up being the complicated bit.

Member

dmlap commented Dec 23, 2014

Yes, that's how I normally do my testing. Getting things setup so I could test on port 80 ended up being the complicated bit.

@dmlap dmlap closed this in c939ab8 Dec 23, 2014

@dmlap dmlap deleted the dmlap:hotfix/ie-accidental-xdr branch Dec 23, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment