Add VERSION key to main VJS object. Closes #1756 #1798

Closed
wants to merge 4 commits into
from

Conversation

Projects
None yet
2 participants
@mmcc
Member

mmcc commented Jan 12, 2015

Pretty straight forward.

I also fat fingered the branch name. How dare contrib not protect me from myself!

@heff

This comment has been minimized.

Show comment
Hide comment
@heff

heff Jan 12, 2015

Member

LGTM!

Member

heff commented Jan 12, 2015

LGTM!

src/js/core.js
@@ -77,6 +77,12 @@ vjs.CDN_VERSION = 'GENERATED_CDN_VSN';
vjs.ACCESS_PROTOCOL = ('https:' == document.location.protocol ? 'https://' : 'http://');
+/**
+* Full player version
+* @type {number}

This comment has been minimized.

@heff

heff Jan 12, 2015

Member

Technically it's still a string type

@heff

heff Jan 12, 2015

Member

Technically it's still a string type

src/js/core.js
+* Full player version
+* @type {string}
+*/
+vjs.VERSION = 'GENERATED_FULL_VSN';

This comment has been minimized.

@heff

heff Jan 16, 2015

Member

This will probably need to be exported...

@heff

heff Jan 16, 2015

Member

This will probably need to be exported...

This comment has been minimized.

@heff

heff Jan 16, 2015

Member

Or just use a string key

@heff

heff Jan 16, 2015

Member

Or just use a string key

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment