Removed unnecessary display:none; from text-track-display #1804

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
@mmcc
Member

mmcc commented Jan 14, 2015

No description provided.

@mmcc mmcc changed the title from emoved unnecessary display:none; from text-track-display to Removed unnecessary display:none; from text-track-display Jan 14, 2015

@heff

This comment has been minimized.

Show comment
Hide comment
@heff

heff Jan 19, 2015

Member

Why's it unnecessary, and is this fixing a specific bug?

Member

heff commented Jan 19, 2015

Why's it unnecessary, and is this fixing a specific bug?

@mmcc

This comment has been minimized.

Show comment
Hide comment
@mmcc

mmcc Jan 20, 2015

Member

An issue was never opened, but the bug was discussed in PR comments

Since the track is actually added / removed from the dom for each cue point, it's redundant to also unhide it. I can't think of a situation that this would break, but I could be overlooking something. Either way, we need to make sure to resolve this before cutting a new release since this is currently broken in master.

Member

mmcc commented Jan 20, 2015

An issue was never opened, but the bug was discussed in PR comments

Since the track is actually added / removed from the dom for each cue point, it's redundant to also unhide it. I can't think of a situation that this would break, but I could be overlooking something. Either way, we need to make sure to resolve this before cutting a new release since this is currently broken in master.

@heff

This comment has been minimized.

Show comment
Hide comment
@heff

heff Jan 22, 2015

Member

LGTM!

Member

heff commented Jan 22, 2015

LGTM!

@mmcc mmcc closed this in 78e95e1 Jan 22, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment