New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/chs localization #1841

Closed
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@DevGavin
Contributor

DevGavin commented Feb 1, 2015

As discussed.
#1826 (comment)

DevGavin added some commits Oct 17, 2014

Add Chinese Simplified localization file.
Found one new string that may needs localization ("The video is encrypted and we do not have the keys to decrypt it.").

Was not able to run test on my Windows 8.1 computer.
When run grunt, it complains:
Warning: Command failed: 'java' is not recognized as an internal or external command.
When run grunt test, it complains:
PhantomJS 1.9.7 (Windows 8) Player Minified should be able to access expected player API methods FAILED.
Although the tests are failed, I don't see the localization has anything to do with the error.
@heff

This comment has been minimized.

Show comment
Hide comment
@heff

heff Feb 11, 2015

Member

I think your branch was based on master prior to adding the zh.json, because this pull request only shows a file addition, not a file name change. I think I can still make this work though. Thanks for the help!!

Member

heff commented Feb 11, 2015

I think your branch was based on master prior to adding the zh.json, because this pull request only shows a file addition, not a file name change. I think I can still make this work though. Thanks for the help!!

@heff heff closed this in 1036338 Feb 12, 2015

@heff

This comment has been minimized.

Show comment
Hide comment
@heff

heff Feb 12, 2015

Member

Thanks @DevGavin!

Member

heff commented Feb 12, 2015

Thanks @DevGavin!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment