Feature/chs localization #1841
Closed
Feature/chs localization #1841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Found one new string that may needs localization ("The video is encrypted and we do not have the keys to decrypt it.").
Was not able to run test on my Windows 8.1 computer.
When run grunt, it complains:
Warning: Command failed: 'java' is not recognized as an internal or external command.
When run grunt test, it complains:
PhantomJS 1.9.7 (Windows 8) Player Minified should be able to access expected player API methods FAILED.
Although the tests are failed, I don't see the localization has anything to do with the error.
As discussed. videojs#1826 (comment)
|
I think your branch was based on master prior to adding the zh.json, because this pull request only shows a file addition, not a file name change. I think I can still make this work though. Thanks for the help!! |
|
Thanks @DevGavin! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed.
#1826 (comment)