Implement vjs-ended class #1857

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
3 participants
@mister-ben
Contributor

mister-ben commented Feb 11, 2015

Adds a vjs-ended class when playback ends, and removes it on a replay. Closes #1675.

@heff

This comment has been minimized.

Show comment
Hide comment
@heff

heff Feb 11, 2015

Member

Whoa, with tests even, very nice! I think we need to reset it on loadstart also, because a new source doesn't have to autoplay.

Member

heff commented Feb 11, 2015

Whoa, with tests even, very nice! I think we need to reset it on loadstart also, because a new source doesn't have to autoplay.

@mister-ben

This comment has been minimized.

Show comment
Hide comment
@mister-ben

mister-ben Feb 11, 2015

Contributor

Ah yes of course it should reset then. Will add.

Contributor

mister-ben commented Feb 11, 2015

Ah yes of course it should reset then. Will add.

@dmlap

This comment has been minimized.

Show comment
Hide comment
@dmlap

dmlap Feb 11, 2015

Member

The spec, for reference.

Member

dmlap commented Feb 11, 2015

The spec, for reference.

@heff

This comment has been minimized.

Show comment
Hide comment
@heff

heff Feb 11, 2015

Member

lgtm! @dmlap or anyone else, can we get a second confirmation?

Member

heff commented Feb 11, 2015

lgtm! @dmlap or anyone else, can we get a second confirmation?

@dmlap

This comment has been minimized.

Show comment
Hide comment
@dmlap

dmlap Feb 12, 2015

Member

Looks good to me, too.

Member

dmlap commented Feb 12, 2015

Looks good to me, too.

@heff heff referenced this pull request Apr 1, 2015

Closed

Add a has-ended class name #1675

@mister-ben mister-ben deleted the mister-ben:feature/ended branch Aug 10, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment