New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable native text tracks by default in html5 #1865

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@gkatsev
Member

gkatsev commented Feb 13, 2015

Chrome, and possibly some other browsers, show captions by default, which is unwanted behavior.
Instead, on loadstart, change the mode of each captions or subtitles track to 'disabled'.
This is done in loadstart because trying to change data of text tracks
wholesale any earlier will be a no-op.

This has been tested with autoplaying videos in chrome.

Disable native text tracks by default in html5
Chrome, and possibly some other browsers, show captions by default, which is unwanted behavior.
Instead, on loadstart, change the mode of each captions or subtitles track to 'disabled'.
This is done in loadstart because trying to change data of text tracks
wholesale any earlier will be a no-op.

@gkatsev gkatsev added this to the Captions milestone Feb 13, 2015

@heff

This comment has been minimized.

Show comment
Hide comment
@heff

heff Feb 14, 2015

Member

lgtm!

Member

heff commented Feb 14, 2015

lgtm!

@heff

This comment has been minimized.

Show comment
Hide comment
@heff

heff Feb 14, 2015

Member

Safari also shows captions by default, but not subtitles.

There's a related Chrome bug for this.

Member

heff commented Feb 14, 2015

Safari also shows captions by default, but not subtitles.

There's a related Chrome bug for this.

@gkatsev gkatsev closed this in 52e6768 Feb 14, 2015

@gkatsev gkatsev deleted the gkatsev:hide-captions-by-default branch Feb 14, 2015

@heff heff referenced this pull request Aug 3, 2015

Closed

Fix track onload #2412

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment