New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed woff linegap error. Closes #1775 #1870

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@mister-ben
Contributor

mister-ben commented Feb 17, 2015

Woff font metrics have been edited to remove an invalid linegap value. I see no difference in appearance between the original and this font on Firefox, but would appreciate any additional verification.

http://jsbin.com/axedog - original
http://jsbin.com/tufesihora - this fix

Supercedes #1796

@mmcc

This comment has been minimized.

Show comment
Hide comment
@mmcc

mmcc Feb 17, 2015

Member

👍 I think this looks good, we should be able to get this in with 4.12 tomorrow. Thanks, @mister-ben.

Member

mmcc commented Feb 17, 2015

👍 I think this looks good, we should be able to get this in with 4.12 tomorrow. Thanks, @mister-ben.

@mmcc mmcc added the confirmed label Feb 17, 2015

@heff

This comment has been minimized.

Show comment
Hide comment
@heff

heff Feb 17, 2015

Member

lgtm!

Member

heff commented Feb 17, 2015

lgtm!

@heff heff added enhancement bug and removed enhancement labels Feb 17, 2015

@mister-ben mister-ben deleted the mister-ben:hotfix/woff branch Aug 10, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment