Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Chrome persisting loading spinner even after successful seek #240

Closed
wants to merge 1 commit into from

2 participants

Dan Connor Steve Heffernan
Dan Connor

Expected:
1. Load up videojs.com
2. hit play.
3. In the console in Chrome enter the following:
V.players.home_video.currentTime("30")
4. The video seeks to the time, plays, and dismisses the spinner

Actual:
1. Load up videojs.com
2. hit play
3. In the console in Chrome enter the following:
V.players.home_video.currentTime("30")
4. The video seeks to the time, plays, and the spinner persists

Analysis:
Chrome is not firing the 'playing' event. If we are going to hook the 'seeking' event we should also hook the 'seeked' event.

Sorry for the duplicate issue with #239. I tried associating this pull request with it using the 'hub' command line tool but it didn't work properly.

Steve Heffernan heff closed this pull request from a commit
Steve Heffernan heff Merge branch 'hotfix/fix-chrome-seeking-spinner' fixes #240
Conflicts:
	src/controls.js
fc6d1b1
Steve Heffernan heff closed this in fc6d1b1
Steve Heffernan
Owner

Strange that happens through the console and not normal seeking which calls the same method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
This page is out of date. Refresh to see the latest.
Showing with 7 additions and 1 deletion.
  1. +7 −1 src/controls.js
8 src/controls.js
View
@@ -239,6 +239,12 @@ _V_.LoadingSpinner = _V_.Component.extend({
player.addEvent("playing", _V_.proxy(this, this.hide));
player.addEvent("seeking", _V_.proxy(this, this.show));
+
+ // in some browsers seeking does not trigger the 'playing' event,
+ // so we also need to trap 'seeked' if we are going to set a
+ // 'seeking' event
+ player.addEvent("seeked", _V_.proxy(this, this.hide));
+
player.addEvent("error", _V_.proxy(this, this.show));
// Not showing spinner on stalled any more. Browsers may stall and then not trigger any events that would remove the spinner.
@@ -843,4 +849,4 @@ _V_.MenuItem = _V_.Button.extend({
}
}
-});
+});
Something went wrong with that request. Please try again.