'contrib release' should only pull changes from 'upstream' and not push things to 'origin' #2723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -54,19 +54,44 @@ | |||
| [ "npm install", "Download dependencies"] | |||
| ] | |||
| }, | |||
| "upstream": { | |||
There was a problem hiding this comment.
It feels off to have this as contrib update upstream master since we're not 'updating' upstream master, we're fetching/pulling/getting upstream master and updating local master vs remote master. Should we have update local master and update remote master?
It's also just two commands if we want to just not have a separate task for it.
There was a problem hiding this comment.
We can. So, would update local just to the pull and update remote also do the push?
Keep 'update master' as 'update remote master' alias.
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.