New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flash Player Events Data #2748

Closed
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@alex-phillips
Contributor

alex-phillips commented Oct 27, 2015

These changes add the textdata event emitted from the Flash module (PR: videojs/video-js-swf#188). In order for this event to receive the text data from the SWF, this change also passes all additional parameters from the triggered event into the handler in the JS.

@pam

This comment has been minimized.

Show comment
Hide comment
@pam

pam Oct 27, 2015

Tests failed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: BUSTED

Commit: a4b4f9a
Build details: https://travis-ci.org/pam/video.js/builds/87662071

(Please note that this is a fully automated comment.)

pam commented Oct 27, 2015

Tests failed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: BUSTED

Commit: a4b4f9a
Build details: https://travis-ci.org/pam/video.js/builds/87662071

(Please note that this is a fully automated comment.)

@alex-phillips

This comment has been minimized.

Show comment
Hide comment
@alex-phillips

alex-phillips Nov 17, 2015

Contributor

Can we get this test to rerun without pushing a commit? I'm not sure the failure was related to my code change.

Contributor

alex-phillips commented Nov 17, 2015

Can we get this test to rerun without pushing a commit? I'm not sure the failure was related to my code change.

@gkatsev

This comment has been minimized.

Show comment
Hide comment
@gkatsev

gkatsev Nov 17, 2015

Member

Yes, though, I'm not sure I want to take on the maintenance for this since we're trying to move away from flash as much as possible.

@pam retry

Member

gkatsev commented Nov 17, 2015

Yes, though, I'm not sure I want to take on the maintenance for this since we're trying to move away from flash as much as possible.

@pam retry

@alex-phillips

This comment has been minimized.

Show comment
Hide comment
@alex-phillips

alex-phillips Nov 17, 2015

Contributor

I totally understand, but it really is a only a single event passed up from the SWF though and the possibility of other arguments passed up (otherwise, undefined or null). Would it really be that much more maintenance?

Contributor

alex-phillips commented Nov 17, 2015

I totally understand, but it really is a only a single event passed up from the SWF though and the possibility of other arguments passed up (otherwise, undefined or null). Would it really be that much more maintenance?

@alex-phillips

This comment has been minimized.

Show comment
Hide comment
@alex-phillips

alex-phillips Nov 17, 2015

Contributor

Seemed to fail again. I have a BrowserStack account of my own. I should be able to run these tests on my own machine as long as I export the proper ENV variables, correct?

Contributor

alex-phillips commented Nov 17, 2015

Seemed to fail again. I have a BrowserStack account of my own. I should be able to run these tests on my own machine as long as I export the proper ENV variables, correct?

@gkatsev

This comment has been minimized.

Show comment
Hide comment
@gkatsev

gkatsev Nov 17, 2015

Member

@pam retry

Member

gkatsev commented Nov 17, 2015

@pam retry

@gkatsev

This comment has been minimized.

Show comment
Hide comment
@gkatsev

gkatsev Nov 17, 2015

Member

Now it's trying again.

Member

gkatsev commented Nov 17, 2015

Now it's trying again.

@pam

This comment has been minimized.

Show comment
Hide comment
@pam

pam Nov 17, 2015

Tests failed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: BUSTED

Commit: a4b4f9a
Build details: https://travis-ci.org/pam/video.js/builds/91634231

(Please note that this is a fully automated comment.)

pam commented Nov 17, 2015

Tests failed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: BUSTED

Commit: a4b4f9a
Build details: https://travis-ci.org/pam/video.js/builds/91634231

(Please note that this is a fully automated comment.)

@alex-phillips

This comment has been minimized.

Show comment
Hide comment
@alex-phillips

alex-phillips Nov 17, 2015

Contributor

@gkatsev is there any way to run the coveralls test locally? As I said, I have my own BrowserStack credentials but if I attempt to run it I get the following output:

Running "coveralls:all" (coveralls) task
>> No src files could be found for grunt-coveralls
Warning: Task "coveralls:all" failed. Use --force to continue.

Aborted due to warnings.

Just a little information on why we're wanting this feature: this has great value, especially for broadcasters (we are a news station and are working to integrate this player as our new video player) who, by law, have to provide closed captions for live streams, which is currently done through RTMP in our system.

Contributor

alex-phillips commented Nov 17, 2015

@gkatsev is there any way to run the coveralls test locally? As I said, I have my own BrowserStack credentials but if I attempt to run it I get the following output:

Running "coveralls:all" (coveralls) task
>> No src files could be found for grunt-coveralls
Warning: Task "coveralls:all" failed. Use --force to continue.

Aborted due to warnings.

Just a little information on why we're wanting this feature: this has great value, especially for broadcasters (we are a news station and are working to integrate this player as our new video player) who, by law, have to provide closed captions for live streams, which is currently done through RTMP in our system.

@gkatsev

This comment has been minimized.

Show comment
Hide comment
@gkatsev

gkatsev Nov 17, 2015

Member

Actually, it's failing because of the various warnings. If you rebase against master it should succeed.

Member

gkatsev commented Nov 17, 2015

Actually, it's failing because of the various warnings. If you rebase against master it should succeed.

@pam

This comment has been minimized.

Show comment
Hide comment
@pam

pam Nov 17, 2015

Tests passed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: CONFIRMED

Commit: 7a7ef14
Build details: https://travis-ci.org/pam/video.js/builds/91653286

(Please note that this is a fully automated comment.)

pam commented Nov 17, 2015

Tests passed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: CONFIRMED

Commit: 7a7ef14
Build details: https://travis-ci.org/pam/video.js/builds/91653286

(Please note that this is a fully automated comment.)

@alex-phillips

This comment has been minimized.

Show comment
Hide comment
@alex-phillips

alex-phillips Nov 17, 2015

Contributor

@gkatsev Awesome, thanks for the help. For what it's worth, this goes with the video-js-swf PR here: videojs/video-js-swf#188

Contributor

alex-phillips commented Nov 17, 2015

@gkatsev Awesome, thanks for the help. For what it's worth, this goes with the video-js-swf PR here: videojs/video-js-swf#188

@alex-phillips

This comment has been minimized.

Show comment
Hide comment
@alex-phillips

alex-phillips Dec 8, 2015

Contributor

Is there any update on if this could get merged in along with its companion SWF PR? It's extremely important as broadcasters to have flash captions available to comply with legal regulations for our video streams. Thanks!

Contributor

alex-phillips commented Dec 8, 2015

Is there any update on if this could get merged in along with its companion SWF PR? It's extremely important as broadcasters to have flash captions available to comply with legal regulations for our video streams. Thanks!

@alex-phillips

This comment has been minimized.

Show comment
Hide comment
@alex-phillips

alex-phillips Jan 12, 2016

Contributor

Is there any update on this?

Contributor

alex-phillips commented Jan 12, 2016

Is there any update on this?

@gkatsev

This comment has been minimized.

Show comment
Hide comment
@gkatsev

gkatsev Jan 12, 2016

Member

Sorry, with the holidays and everything it's been busy and hectic. We'll try to get to this soon. Thanks.

Member

gkatsev commented Jan 12, 2016

Sorry, with the holidays and everything it's been busy and hectic. We'll try to get to this soon. Thanks.

@alex-phillips

This comment has been minimized.

Show comment
Hide comment
@alex-phillips

alex-phillips Jan 12, 2016

Contributor

Completely understand, just didn't want this to get lost. Thanks for the response!

Contributor

alex-phillips commented Jan 12, 2016

Completely understand, just didn't want this to get lost. Thanks for the response!

@forbesjo forbesjo referenced this pull request Jan 21, 2016

Merged

onTextData Event #188

@alex-phillips

This comment has been minimized.

Show comment
Hide comment
@alex-phillips

alex-phillips Feb 23, 2016

Contributor

Any update on this?

Contributor

alex-phillips commented Feb 23, 2016

Any update on this?

@gkatsev

This comment has been minimized.

Show comment
Hide comment
@gkatsev

gkatsev Jun 20, 2016

Member

@alex-phillips hey, sorry for the super long wait, it keeps getting away from us. Any ideas on how to test this? I'm not sure how to create an rtmp stream with textdata.

Member

gkatsev commented Jun 20, 2016

@alex-phillips hey, sorry for the super long wait, it keeps getting away from us. Any ideas on how to test this? I'm not sure how to create an rtmp stream with textdata.

@gkatsev

This comment has been minimized.

Show comment
Hide comment
@gkatsev

gkatsev Jun 21, 2016

Member

Got it working by using the trial wowza server. Couldn't really get it any other way.

Member

gkatsev commented Jun 21, 2016

Got it working by using the trial wowza server. Couldn't really get it any other way.

Show outdated Hide outdated src/js/player.js
@@ -2767,6 +2776,8 @@ Player.prototype.options_ = {
*/
Player.prototype.handleLoadedMetaData_;
Player.prototype.handleTextData_;

This comment has been minimized.

@gkatsev

gkatsev Jun 21, 2016

Member

Can you add a jsdoc comment here, similar to how loadeddata is below, for example.
I can add it myself when I'm merging if it isn't done by then.

@gkatsev

gkatsev Jun 21, 2016

Member

Can you add a jsdoc comment here, similar to how loadeddata is below, for example.
I can add it myself when I'm merging if it isn't done by then.

This comment has been minimized.

@alex-phillips

alex-phillips Jun 29, 2016

Contributor

@gkatsev Added the JSDoc. Thanks!

@alex-phillips

alex-phillips Jun 29, 2016

Contributor

@gkatsev Added the JSDoc. Thanks!

@gkatsev

This comment has been minimized.

Show comment
Hide comment
@gkatsev

gkatsev Jul 18, 2016

Member

The swf part of this has finally been released as 5.1.0, would you be able to update the dependency to point to that?
Thanks!

Member

gkatsev commented Jul 18, 2016

The swf part of this has finally been released as 5.1.0, would you be able to update the dependency to point to that?
Thanks!

@alex-phillips

This comment has been minimized.

Show comment
Hide comment
@alex-phillips

alex-phillips Jul 18, 2016

Contributor

@gkatsev Version's been updated. Thanks!

Contributor

alex-phillips commented Jul 18, 2016

@gkatsev Version's been updated. Thanks!

@gkatsev

This comment has been minimized.

Show comment
Hide comment
@gkatsev

gkatsev Jul 18, 2016

Member

@alex-phillips cool! Did we lose the jsdoc comment?

Member

gkatsev commented Jul 18, 2016

@alex-phillips cool! Did we lose the jsdoc comment?

@alex-phillips

This comment has been minimized.

Show comment
Hide comment
@alex-phillips

alex-phillips Jul 18, 2016

Contributor

@gkatsev D'oh, missed that during the merge. Fixed!

Contributor

alex-phillips commented Jul 18, 2016

@gkatsev D'oh, missed that during the merge. Fixed!

@gkatsev

This comment has been minimized.

Show comment
Hide comment
@gkatsev

gkatsev Jul 18, 2016

Member

It happens. Thanks.

Member

gkatsev commented Jul 18, 2016

It happens. Thanks.

@misteroneill

This comment has been minimized.

Show comment
Hide comment
@misteroneill
Member

misteroneill commented Jul 18, 2016

LGTM

@gkatsev gkatsev closed this in e7ca49e Jul 18, 2016

@gkatsev

This comment has been minimized.

Show comment
Hide comment
@gkatsev

gkatsev Jul 18, 2016

Member

It's merged! Thanks @alex-phillips.

Member

gkatsev commented Jul 18, 2016

It's merged! Thanks @alex-phillips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment