the first default text tracks will be show by default in emulated tracks #3248
Conversation
|
This turns on captions/subtitles/descriptions if any of them are marked |
|
@dmlap that's what chrome does. Safari does it's own thing where it remembers your last position. Really hard to test this. Looks like firefox only does it for english (so, probably if the srclang matches your browser's locale). |
|
Firefox also doesn't even have a captions button to toggle visibility of the current track on/off like chrome does. |
|
Also, I think most users expect it to just show the first default text track, regardless of the locale. |
| @@ -58,6 +58,19 @@ class TextTrackDisplay extends Component { | |||
| let track = tracks[i]; | |||
| this.player_.addRemoteTextTrack(track); | |||
| } | |||
|
|
|||
| let modesToShow = {'captions': 1, 'subtitles': 1, 'descriptions': 1}; | |||
There was a problem hiding this comment.
Is there a reason you use an object instead of an array?
There was a problem hiding this comment.
Because in operator is O(1) vs indexOf is O(n).
|
Ah oops @dmlap asked a similar question already, my bad |
|
@nickygerritsen heh, it's ok. It made me realize that I need to default descriptions after defaulting captions/subtitles. |
|
Here's an example: http://plnkr.co/edit/rncA4P?p=info |
gkatsev
added
patch
|
I'll add a comment about defaulting to the first track unless there's both a caption/subtitles and a description, in which case captions/subtitles take priority. |
|
Ok, updated with tests and also a comment about what's happening. |
|
Nice, LGTM |
gkatsev
added
confirmed
and removed
needs: LGTM
* upstream/stable: (77 commits) v5.9.2 @gkatsev grouped text track errors in the console, if we can. closes videojs#3259 v5.9.1 @gkatsev fixed text track tests for older IEs. closes videojs#3269 revert 75116d4 adding chrome to travis (videojs#3254) @forbesjo added back the background color to the poster. closes videojs#3267 @gkatsev fixed removeRemoteTextTracks not working with return value from addRemoteTextTracks. closes videojs#3253 @gkatsev made the first emulated text track enabled by default. closes videojs#3248 @mister-ben blacklisted Chrome for Android for playback rate support. closes videojs#3246 @benjipott updated IS_CHROME to not be true on MS Edge. closes videojs#3232 v5.9.0 @andyearnshaw updated document event handlers to use el.ownerDocument. closes videojs#3230 @chrisauclair added ARIA region and label to player element. closes videojs#3227 @MCGallaspy added vttjs to the self-hosting guide. closes videojs#3229 @forbesjo added chrome for PR tests. closes videojs#3235 @OwenEdwards improved handling of deprecated use of Button component. closes videojs#3236 v5.8.8 @seescode fixed dragging on mute toggle changing the volume. Fixes videojs#3036. Closes videojs#3228 @seescode fixed css failing on IE8 due to incorrect ie8 hack. Fixes videojs#3140. Closes videojs#3226. @vtytar fixed auto-setup failing if taking too long to load. Fixes videojs#2386. Closes videojs#3233. ...
Description
As the title suggests, default emulated text tracks will now be shown by default. It will choose the first one from the list.
Specific Changes proposed
Requirements Checklist