New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chrome 50 does not set src attr on video element. #3287

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@rbran100
Contributor

rbran100 commented Apr 29, 2016

#3071

Description

Chrome does not set the src attr and this causes autoplay to never trigger.

Specific Changes proposed

Check current src, it will hold the current source when multiple source video files are used.

Requirements Checklist

  • Feature implemented / Bug fixed
  • Reviewed by Two Core Contributors
@gkatsev

This comment has been minimized.

Show comment
Hide comment
@gkatsev

gkatsev Apr 29, 2016

Member

I made some comments in #3071, I'm not necessarily opposed to making this change but we should understand it fully before merging if we can.

Member

gkatsev commented Apr 29, 2016

I made some comments in #3071, I'm not necessarily opposed to making this change but we should understand it fully before merging if we can.

@gkatsev

This comment has been minimized.

Show comment
Hide comment
@gkatsev

gkatsev Jul 18, 2016

Member

@rbran100 hey, would you want to update this PR against master to get it pulled in?

Member

gkatsev commented Jul 18, 2016

@rbran100 hey, would you want to update this PR against master to get it pulled in?

@gkatsev gkatsev closed this in 5860479 Jul 18, 2016

@gkatsev

This comment has been minimized.

Show comment
Hide comment
@gkatsev

gkatsev Jul 18, 2016

Member

Ended up rebasing this myself and pulilng it in. Thanks!

Member

gkatsev commented Jul 18, 2016

Ended up rebasing this myself and pulilng it in. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment