New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add title to all clickable components #3296

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
@nickygerritsen
Contributor

nickygerritsen commented May 4, 2016

Description

As discussed on Slack yesterday, this will add a title to all clickable components.
I modified the play toggle test to also check for this, as this was the only test that seemed to test for this already.

Because controlText is already called in createEl I had to pass the element to set the title on to the function.

Specific Changes proposed

This sets the title HTML attribute on all clickable components when setting controlText_ initially or changing it using controlText(...).

Requirements Checklist

  • Feature implemented / Bug fixed
  • Unit Tests updated or fixed
  • Reviewed by Two Core Contributors

@nickygerritsen nickygerritsen referenced this pull request May 4, 2016

Closed

Update Dutch language file #3297

1 of 2 tasks complete
* @return {String}
* @method controlText
*/
controlText(text) {
controlText(text, el=this.el()) {

This comment has been minimized.

@gkatsev

gkatsev May 4, 2016

Member

is it possible that this.el() will end up returning nothing?

@gkatsev

gkatsev May 4, 2016

Member

is it possible that this.el() will end up returning nothing?

This comment has been minimized.

@nickygerritsen

nickygerritsen May 4, 2016

Contributor

Only during the first call, because that is made from createEl, at which time this.el() does not eixst yet. Afterwards it should always exist, right?

@nickygerritsen

nickygerritsen May 4, 2016

Contributor

Only during the first call, because that is made from createEl, at which time this.el() does not eixst yet. Afterwards it should always exist, right?

@gkatsev

This comment has been minimized.

Show comment
Hide comment
@gkatsev

gkatsev May 11, 2016

Member

LGTM.

Member

gkatsev commented May 11, 2016

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment