New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Un-deprecate the videojs.players property #3299

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants
@misteroneill
Member

misteroneill commented May 5, 2016

Description

As discussed among core committers, we've decided deprecating this property had too many disadvantages and not enough advantages.

Also, this removes the createDeprecationProxy function as it was only used in the one place anymore.

Specific Changes proposed

  • Removed videojs.players deprecation wrapper.
  • Removed createDeprecationProxy and tests for it.
  • Removed unused import from src/js/video.js.

Requirements Checklist

  • Feature implemented / Bug fixed
  • Reviewed by Two Core Contributors
Un-deprecate videojs.players property
As discussed among core committers, we've decided deprecating this
property had too many disadvantages and not enough advantages.

Also, this removes the `createDeprecationProxy` function as it was only
used in the one place anymore.
@dmlap

This comment has been minimized.

Show comment
Hide comment
@dmlap

dmlap May 5, 2016

Member

We get rid of a file, too? Nice! LGTM

Member

dmlap commented May 5, 2016

We get rid of a file, too? Nice! LGTM

@misteroneill

This comment has been minimized.

Show comment
Hide comment
@misteroneill

misteroneill May 5, 2016

Member

Two files if you count the test - it's a nice bonus!

Member

misteroneill commented May 5, 2016

Two files if you count the test - it's a nice bonus!

@nickygerritsen

This comment has been minimized.

Show comment
Hide comment
@nickygerritsen

nickygerritsen May 6, 2016

Contributor

LGTM!

Contributor

nickygerritsen commented May 6, 2016

LGTM!

@misteroneill misteroneill added the minor label May 6, 2016

@gkatsev gkatsev added the confirmed label May 10, 2016

@misteroneill misteroneill deleted the misteroneill:undeprecate-players branch Jul 25, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment