Also pass tech options to canHandleSource #3303

Closed
wants to merge 1 commit into
from

Projects

None yet

4 participants

@nickygerritsen
Contributor
nickygerritsen commented May 6, 2016 edited

Description

As discussed, this also adds the tech's options to canHandleSource for source handlers.

Specific Changes proposed

It passes the tech options around to make sure it can be used at canHandleSource. Also, some updated unit tests!

Requirements Checklist

  • Feature implemented / Bug fixed
  • Unit Tests updated or fixed
  • Reviewed by Two Core Contributors
@nickygerritsen nickygerritsen Also pass tech options to canHandleSource
da51288
@misteroneill
Member
misteroneill commented May 6, 2016 edited

I expect the implications of this have been discussed in Slack (I can't think of any...)? Either way, code changes LGTM.

@nickygerritsen
Contributor

We discussed some things on Slack yes and @gkatsev proposed we did it this way :)

@dmlap
Member
dmlap commented May 9, 2016

LGTM!

@gkatsev gkatsev added the confirmed label May 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment