New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also pass tech options to canHandleSource #3303

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@nickygerritsen
Contributor

nickygerritsen commented May 6, 2016

Description

As discussed, this also adds the tech's options to canHandleSource for source handlers.

Specific Changes proposed

It passes the tech options around to make sure it can be used at canHandleSource. Also, some updated unit tests!

Requirements Checklist

  • Feature implemented / Bug fixed
  • Unit Tests updated or fixed
  • Reviewed by Two Core Contributors
@misteroneill

This comment has been minimized.

Show comment
Hide comment
@misteroneill

misteroneill May 6, 2016

Member

I expect the implications of this have been discussed in Slack (I can't think of any...)? Either way, code changes LGTM.

Member

misteroneill commented May 6, 2016

I expect the implications of this have been discussed in Slack (I can't think of any...)? Either way, code changes LGTM.

@nickygerritsen

This comment has been minimized.

Show comment
Hide comment
@nickygerritsen

nickygerritsen May 6, 2016

Contributor

We discussed some things on Slack yes and @gkatsev proposed we did it this way :)

Contributor

nickygerritsen commented May 6, 2016

We discussed some things on Slack yes and @gkatsev proposed we did it this way :)

@dmlap

This comment has been minimized.

Show comment
Hide comment
@dmlap

dmlap May 9, 2016

Member

LGTM!

Member

dmlap commented May 9, 2016

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment