Add descriptions and audio button to adaptive classes #3312

Closed
wants to merge 1 commit into
from

Projects

None yet

3 participants

@hartman
Contributor
hartman commented May 10, 2016

Description

In 5.9, a button for descriptions was added to the control bar and in 5.10 a button for audio tracks. Unlike their chapter, captions, subtitle counterparts these were not hidden by the adaptive classes.

Specific Changes proposed

Add these new buttons to the list of buttons hidden in smaller form factor layouts.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
  • Reviewed by Two Core Contributors

This fixes #3308

@hartman hartman Adaptive classes were misisng audio and descriptions
The buttons for descriptions and audio tracks were recently added, but
not yet hidden by the adaptive classes, as their siblings chapters,
subtitles etc are.

Fixes #3308
2baabb6
@gkatsev
Member
gkatsev commented May 10, 2016

Thanks @hartman, LGTM.

@nickygerritsen
Contributor

LGTM

@gkatsev gkatsev added confirmed and removed needs: LGTM labels May 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment