New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add descriptions and audio button to adaptive classes #3312

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
@hartman
Contributor

hartman commented May 10, 2016

Description

In 5.9, a button for descriptions was added to the control bar and in 5.10 a button for audio tracks. Unlike their chapter, captions, subtitle counterparts these were not hidden by the adaptive classes.

Specific Changes proposed

Add these new buttons to the list of buttons hidden in smaller form factor layouts.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
  • Reviewed by Two Core Contributors

This fixes #3308

Adaptive classes were misisng audio and descriptions
The buttons for descriptions and audio tracks were recently added, but
not yet hidden by the adaptive classes, as their siblings chapters,
subtitles etc are.

Fixes #3308
@gkatsev

This comment has been minimized.

Show comment
Hide comment
@gkatsev

gkatsev May 10, 2016

Member

Thanks @hartman, LGTM.

Member

gkatsev commented May 10, 2016

Thanks @hartman, LGTM.

@nickygerritsen

This comment has been minimized.

Show comment
Hide comment
@nickygerritsen

nickygerritsen May 11, 2016

Contributor

LGTM

Contributor

nickygerritsen commented May 11, 2016

LGTM

@gkatsev gkatsev added confirmed and removed needs: LGTM labels May 11, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment