New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Logging for IE < 11 #3356

Closed
wants to merge 5 commits into
from

Conversation

Projects
None yet
2 participants
@misteroneill
Member

misteroneill commented Jun 2, 2016

Description

IE11 introduced expandable objects in the console. Previously, everything was .join()ed and, therefore, objects came through as [object Object], which is not useful. This improves the ES6-ification of the log module and passes objects and arrays through JSON.stringify() before logging them in IE10 and lower.

Some opportunities for ES6 brevity were left out because JSHint does not like them; though, they would pass videojs-standard.

Specific Changes proposed

  • Modifications to the existing utils/log module.

Requirements Checklist

  • Feature implemented / Bug fixed
  • Unit Tests updated or fixed
  • Reviewed by Two Core Contributors
@gkatsev

This comment has been minimized.

Show comment
Hide comment
@gkatsev

gkatsev Jun 20, 2016

Member

Can you add a test for the JSON.stringify functionality?

Member

gkatsev commented Jun 20, 2016

Can you add a test for the JSON.stringify functionality?

@gkatsev gkatsev removed the confirmed label Jun 20, 2016

misteroneill added some commits Jun 2, 2016

Improve logging for IE < 11
IE11 introduced expandable objects in the console. Previously,
everything was .join()ed and, therefore, objects came through as
"[object Object]", which is not useful. This improves the ES6-ification
of the log module and passes objects and arrays through JSON.stringify
before logging them in IE10 and lower.

Some opportunities for ES6 brevity were left out because JSHint does not
like them; though, they would pass videojs-standard.
@misteroneill

This comment has been minimized.

Show comment
Hide comment
@misteroneill

misteroneill Jul 6, 2016

Member

You're right. 😄 I added a test for that behavior. Unfortunately, it meant exposing the logByType function and giving it an optional argument only used for testing, which broke TextTrack tests (which have been fixed).

Rebased on master too.

Member

misteroneill commented Jul 6, 2016

You're right. 😄 I added a test for that behavior. Unfortunately, it meant exposing the logByType function and giving it an optional argument only used for testing, which broke TextTrack tests (which have been fixed).

Rebased on master too.

misteroneill added some commits Jul 7, 2016

@gkatsev gkatsev closed this in 13d349b Jul 18, 2016

@misteroneill misteroneill deleted the misteroneill:better-ie-logging branch Jul 19, 2016

@misteroneill misteroneill referenced this pull request Jul 19, 2016

Closed

Separate fn.apply and stringify checks #3444

5 of 6 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment