rework build to seperate out ie8 specific sass
Moving the IE8 stuff to another sass file, unfortunately, won't fix the issue. It needs to be turned into a plain old css file (so, sass won't turn the special characters into utf8/unicode characters).
Also, we don't want to create any breaking changes in patch or minor releases. Would be nice if this extra file can just be appended together with the file generated from sass.
Also, wanted to thank you for getting started on this. Let me know if you can get to the changes above, otherwise, I can probably pull your changes in and make the other changes as well.
gotcha. Thanks for the extra clarifications @gkatsev - I should be able to take care of this. No worries at all.
modified grunt for ie8 injection into main css
the only thing outstanding is that the unminified src/css/ie8.css isn't being appended to build/temp/video-js.css
Having the temp file not include the ie8 piece is fine, I think.
While I think that build/temp/video-js.css is fine if it's missing, it does need to be in dist/video-js.css. Looking into what needs to change. Maybe we can still get it into build/temp/video-js.css anyway.
Ah, we can use concat to do this. I'll make a PR for this against your PR.
Made a PR for this, see erikyuzwa#1
What it does is uses concat to add the ie8-only files into build/temp/video-js.css after the sass task compiles all the sass stuff into build/temp/video-js.css. Then we don't need the cssmin changes because the ie8 changes are already in the file.
Love this. LGTM.
landed in d86d4b2 and 1ff9f38.
Thanks @erikyuzwa for starting this!