Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix for accessibility: Modal Dialog Button #3400
This fix is to make the screen reader read the Modal Dialog Close button better.
Specific Changes proposed
Please list the specific changes involved in this pull request.
referenced this pull request
Jun 27, 2016
@gkatsev I think the
@mister-ben is there a specific procedure for adding new text which needs translating? Should it just be added into the
@mister-ben Sure, we could update the template.
Also I was using Google translate to translate the text as I do not know many of the languages.
Google translate really isn't that good, and missing keys won't break anything.
I'd let a native speaker add a good translation when they discover there are missing keys, which has happened fairly well organically so far, rather than add poor translations.
Again, I think it's worth putting something together that will check for missing translations (again much simpler to check for missing keys) so contributors speaking a language can know what needs addressing. I can see if I can figure something out for that.
I've looked at how localize() works, and tested it, and it seems like it can handle both a missing key and
So this is more of a style decision than a programmatic decision. Personally, I think having null values in the language files (the second pattern) is confusing, rather than having
@mister-ben it would certainly be useful if something could detect whether/which language files are incomplete, and maybe also enforce what you decide about whether null keys are allowed?
@vdeshpande can you undo the changes in everything except