New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed Captions Button on touch devices w/ mouse #3404

Closed
wants to merge 6 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@ldayananda
Contributor

ldayananda commented Jun 28, 2016

Description

With the Graphite skin, on devices that are touch enabled and can use a mouse, menus close immediately when mousing out of the menu button. This behavior is not observed in the Luna skin.

Specific Changes proposed

  • Changes use of mouseout to mouseleave.
  • Changes the level the mouse event handler is bound.
  • Makes use of unpressButton() to ensure the menu knows it is closed when the mouse leaves the menu.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Unit Tests updated or fixed(not necessary here, current unit tests are successful)
  • Reviewed by Two Core Contributors
Show outdated Hide outdated src/js/menu/menu-button.js
@@ -7,6 +7,7 @@ import Menu from './menu.js';
import * as Dom from '../utils/dom.js';
import * as Fn from '../utils/fn.js';
import toTitleCase from '../utils/to-title-case.js';
import * as Events from '../utils/events.js';

This comment has been minimized.

@gkatsev

gkatsev Jun 28, 2016

Member

This is no longer necessary.

@gkatsev

gkatsev Jun 28, 2016

Member

This is no longer necessary.

@gkatsev

This comment has been minimized.

Show comment
Hide comment
@gkatsev

gkatsev Jun 28, 2016

Member

LGTM

Member

gkatsev commented Jun 28, 2016

LGTM

@misteroneill

This comment has been minimized.

Show comment
Hide comment
@misteroneill
Member

misteroneill commented Jul 5, 2016

LGTM

@gkatsev gkatsev added the confirmed label Jul 5, 2016

@gkatsev gkatsev closed this in 7ae2c88 Jul 18, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment