New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate errorDisplay as it can be disabled in options (fixes #3014) #3440

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
@ntadej

ntadej commented Jul 19, 2016

Description

All UI elements can be disabled in options for example

{
  'posterImage': false,
  'textTrackDisplay': false,
  'loadingSpinner': false,
  'bigPlayButton': false,
  'controlBar': false,
  'errorDisplay': false,
  'textTrackSettings': false
}

When errorDisplay is disabled it does not exist anymore. Thus its existence needs to be validated to avoid crashes. The one fixed occurs immediately after player is initialized.

Specific Changes proposed

Validate existence of this.errorDisplay. This fixes #3014.

Requirements Checklist

  • Bug fixed
  • Reviewed by Two Core Contributors
@gkatsev

This comment has been minimized.

Show comment
Hide comment
@gkatsev

gkatsev Jul 19, 2016

Member

LGTM.

Member

gkatsev commented Jul 19, 2016

LGTM.

@BrandonOCasey

This comment has been minimized.

Show comment
Hide comment
@BrandonOCasey

BrandonOCasey Jul 19, 2016

Contributor

LGTM

Contributor

BrandonOCasey commented Jul 19, 2016

LGTM

@gkatsev gkatsev closed this in 4b4954e Jul 19, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment