New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate fn.apply and stringify checks #3444

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@misteroneill
Member

misteroneill commented Jul 19, 2016

Description

This fixes #3442 which was introduced by #3356.

IE10 correctly supports console.*.apply, but should also get the "stringification" treatment (because it uselessly logs [object Object] and similar). This avoids an issue where an "Invalid calling object" was triggered when trying to call console method(s) from a cached reference (without a proper context object).

Specific Changes proposed

  • Split out the logic around whether console.*.apply is supported and whether or not arguments should be stringified.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
  • Reviewed by Two Core Contributors
Separate fn.apply and stringify checks
IE10 correctly supports console.*.apply, but should also get the
stringification treatment (because it uselessly logs "[object Object]"
and similar). This avoids an issue where an "Invalid calling object" was
triggered when trying to call console method(s) from a cached value.
@misteroneill

This comment has been minimized.

Show comment
Hide comment
@misteroneill

misteroneill Jul 19, 2016

Member

Also: I tested (again) this change in all supported IE versions and it worked as expected.

Member

misteroneill commented Jul 19, 2016

Also: I tested (again) this change in all supported IE versions and it worked as expected.

@gkatsev

This comment has been minimized.

Show comment
Hide comment
@gkatsev

gkatsev Jul 19, 2016

Member

LGTM

Member

gkatsev commented Jul 19, 2016

LGTM

@gkatsev gkatsev closed this in 5b15feb Jul 20, 2016

@misteroneill misteroneill deleted the misteroneill:fix-3442 branch Jul 21, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment