New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add es6-shim to tests, fixes the Flash test #3453

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@gkatsev
Member

gkatsev commented Jul 22, 2016

Description

Add es6-shim to the tests. This allows us to use newer features in the tests where it's useful. This fixes the test issues we're seeing when #3128 was merged in.

@gkatsev

This comment has been minimized.

Show comment
Hide comment
@gkatsev

gkatsev Jul 22, 2016

Member

This fixes the Flash test. The other tests will be fixed in other PRs.

Member

gkatsev commented Jul 22, 2016

This fixes the Flash test. The other tests will be fixed in other PRs.

@misteroneill

This comment has been minimized.

Show comment
Hide comment
@misteroneill
Member

misteroneill commented Jul 22, 2016

LGTM

@gkatsev gkatsev closed this in 3e9c53f Jul 22, 2016

@gkatsev gkatsev deleted the fix-flash-duration-tests branch Jul 22, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment