do a nullcheck for navigator. default to null for ios_version #3502

Closed
wants to merge 2 commits into
from

Projects

None yet

2 participants

@gkatsev
Member
gkatsev commented Aug 5, 2016

This allows us to require videojs in node or tonicdev.com

const browser = require('./browser.js');
console.log(browser);
{ IS_IPAD: false,
  IS_IPHONE: false,
  IS_IPOD: false,
  IS_IOS: false,
  IOS_VERSION: null,
  IS_ANDROID: false,
  ANDROID_VERSION: null,
  IS_OLD_ANDROID: false,
  IS_NATIVE_ANDROID: false,
  IS_FIREFOX: false,
  IS_EDGE: false,
  IS_CHROME: false,
  IS_IE8: false,
  IE_VERSION: null,
  TOUCH_ENABLED: false,
  BACKGROUND_SIZE_SUPPORTED: false }

/cc @ljharb

@gkatsev gkatsev do a nullcheck for navigator. default to null for ios_version
4c60fbb
@gkatsev gkatsev added this to the 3.12 build-improvements milestone Aug 5, 2016
@gkatsev gkatsev added the needs: LGTM label Aug 5, 2016
@misteroneill
Member

There's another navigator.userAgent here.

@gkatsev gkatsev do a navigator nullcheck in Html5#supportsFullscreen
0f109fc
@misteroneill
Member

LGTM

@gkatsev gkatsev added confirmed and removed needs: LGTM labels Aug 5, 2016
@gkatsev gkatsev closed this in f947ed7 Aug 5, 2016
@gkatsev gkatsev deleted the gkatsev:user-agent branch Aug 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment