New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do a nullcheck for navigator. default to null for ios_version #3502

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
2 participants
@gkatsev
Member

gkatsev commented Aug 5, 2016

This allows us to require videojs in node or tonicdev.com

const browser = require('./browser.js');
console.log(browser);
{ IS_IPAD: false,
  IS_IPHONE: false,
  IS_IPOD: false,
  IS_IOS: false,
  IOS_VERSION: null,
  IS_ANDROID: false,
  ANDROID_VERSION: null,
  IS_OLD_ANDROID: false,
  IS_NATIVE_ANDROID: false,
  IS_FIREFOX: false,
  IS_EDGE: false,
  IS_CHROME: false,
  IS_IE8: false,
  IE_VERSION: null,
  TOUCH_ENABLED: false,
  BACKGROUND_SIZE_SUPPORTED: false }

/cc @ljharb

@gkatsev gkatsev added this to the 3.12 build-improvements milestone Aug 5, 2016

@gkatsev gkatsev added the needs: LGTM label Aug 5, 2016

@misteroneill

This comment has been minimized.

Show comment
Hide comment
@misteroneill

misteroneill Aug 5, 2016

Member

There's another navigator.userAgent here.

Member

misteroneill commented Aug 5, 2016

There's another navigator.userAgent here.

@misteroneill

This comment has been minimized.

Show comment
Hide comment
Member

misteroneill commented Aug 5, 2016

LGTM

@gkatsev gkatsev added confirmed and removed needs: LGTM labels Aug 5, 2016

@gkatsev gkatsev closed this in f947ed7 Aug 5, 2016

@gkatsev gkatsev deleted the gkatsev:user-agent branch Aug 5, 2016

@ljharb ljharb referenced this pull request Aug 16, 2016

Closed

Still broken in node #3536

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment