Use videojs-standard 5.2 and fix two errors #3508

Closed
wants to merge 4 commits into
from

Projects

None yet

3 participants

@misteroneill
Member

Description

This updates to videojs-standard 5.2 or higher and fixes two errors. The benefit of the upgrade is that we get correct exit codes from the videojs-standard CLI tool so the git pre-push hook actually works to prevent invalid pushes.

Requirements Checklist

  • Feature implemented / Bug fixed
  • Reviewed by Two Core Contributors
@gkatsev gkatsev and 1 other commented on an outdated diff Aug 8, 2016
build/grunt.js
@@ -482,6 +483,7 @@ module.exports = function(grunt) {
);
grunt.registerTask('dist', [
+ 'shell:lint',
@gkatsev
gkatsev Aug 8, 2016 Member

should we lint as part of running dist?

@misteroneill
misteroneill Aug 8, 2016 Member

Hmm, probably not. Good call.

@BrandonOCasey BrandonOCasey referenced this pull request Aug 8, 2016
Closed

fix errors for quotes rule #3504

1 of 2 tasks complete
@BrandonOCasey
Contributor

LGTM

@BrandonOCasey BrandonOCasey referenced this pull request Aug 8, 2016
Closed

Qunit 2 Style #3509

2 of 2 tasks complete
@gkatsev
Member
gkatsev commented Aug 8, 2016

LGTM

@gkatsev gkatsev added confirmed and removed needs: LGTM labels Aug 8, 2016
misteroneill added some commits Aug 8, 2016
@misteroneill misteroneill Use videojs-standard 5.2 and fix two errors 5a8845b
@misteroneill misteroneill Lint on build. 55719f8
@misteroneill misteroneill Use Node 4 on Travis 111127a
@misteroneill misteroneill Don't lint on dist build
ed3285f
@gkatsev gkatsev added the minor label Aug 11, 2016
@gkatsev gkatsev modified the milestone: 3.12 build-improvements Aug 11, 2016
@gkatsev gkatsev closed this in b3e4e95 Aug 11, 2016
@misteroneill misteroneill deleted the misteroneill:update-standard branch Aug 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment