Feature/clean up player objects in tests #3524

Closed
wants to merge 1 commit into
from

Projects

None yet

4 participants

@rlchung
Contributor
rlchung commented Aug 12, 2016

Description

Fixed Issue #2895 ; cleaned up player objects in tests.
Added player.dispose() function where necessary.

Specific Changes proposed

N/A

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
  • Reviewed by Two Core Contributors
@rlchung rlchung closed this Aug 12, 2016
@rlchung rlchung reopened this Aug 12, 2016
@BrandonOCasey
Contributor

From a quick once over in each of the files it looks like you got all the dispose calls that we were missing!
EXCELLENT

@BrandonOCasey
Contributor
BrandonOCasey commented Aug 12, 2016 edited

also LGTM 😄

@misteroneill
Member

Nice. LGTM. Thanks @rlchung

Ultimately, we'll want to refactor the tests such that this can be achieved in a afterEach step, but this is perfect for now.

@gkatsev
Member
gkatsev commented Aug 15, 2016

LGTM.
Would you be able to rebase this against master?

@rlchung rlchung fixes #2894 for relevant tests
fixes #2895 for button.test.js

fixes #2895 for controls.test.js

fixed #2895 for setup.test.js

fixed #2895 for video.test.js

fixes #2895 for audio-tracks.test.js

fixed #2895 for text-tracks.test.js

fixed #2895 for video-tracks.test.js

fixes #2895 cleans up player objects in tests

fixes #2895 revision for trailing space error
55084bb
@rlchung
Contributor
rlchung commented Aug 15, 2016

@gkatsev Done!

@gkatsev
Member
gkatsev commented Aug 15, 2016

Awesome, thanks!

@gkatsev
Member
gkatsev commented Aug 25, 2016

Oops, forgot the # in the commit. This is closed by af6beb2.

Thanks @rlchung.

@gkatsev gkatsev closed this Aug 25, 2016
@rlchung rlchung deleted the rlchung:feature/clean-up-player-objects-in-tests branch Aug 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment