New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert back to qunitjs 1.x. Add es5-shim to tests #3533

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
@gkatsev
Member

gkatsev commented Aug 13, 2016

QUnitjs 2.0 doesn't seem to support IE8. I asked for clarification here: qunitjs/qunit#1031

I'm merging this in immediately to unbreak the build but please someone review this when you get a chance.

@gkatsev gkatsev added the needs: LGTM label Aug 13, 2016

@gkatsev gkatsev closed this in 6385d1d Aug 13, 2016

@gkatsev gkatsev deleted the revert-qunit branch Aug 13, 2016

@misteroneill

This comment has been minimized.

Show comment
Hide comment
Member

misteroneill commented Aug 15, 2016

LGTM

@misteroneill misteroneill added confirmed and removed needs: LGTM labels Aug 15, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment