Add tests to make sure that bundling works as well as require in node.js #3558

Closed
wants to merge 4 commits into
from

Projects

None yet

3 participants

@gkatsev
Member
gkatsev commented Aug 22, 2016

Description

Fixes #3541

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Unit Tests updated or fixed
  • Reviewed by Core Contributors
gkatsev added some commits Aug 22, 2016
@gkatsev gkatsev add a test that requiring videojs in node doesn't throw 885787c
@gkatsev gkatsev add a simple test that bundling using browserify works 6b778c5
@gkatsev gkatsev test webpack bundling
98a0693
@gkatsev gkatsev fix linting
d700b87
@gkatsev
Member
gkatsev commented Aug 22, 2016

@ljharb if you have any input on this as well, would be appreciated.

@ljharb
Contributor
ljharb commented Aug 22, 2016

LGTM

@misteroneill
Member

LGTM

We should definitely do something like this in the plugin generator.

@gkatsev gkatsev added a commit that closed this pull request Aug 24, 2016
@gkatsev gkatsev @gkatsev added tests for webpack and browserify bundling and node.js …
…requiring. closes #3558
c154518
@gkatsev gkatsev closed this in c154518 Aug 24, 2016
@gkatsev gkatsev deleted the require-tests branch Aug 24, 2016
@helenjer helenjer pushed a commit to helenjer/video.js that referenced this pull request Sep 6, 2016
@gkatsev gkatsev + Pravdina Elena @gkatsev added tests for webpack and browserify bundling and node.js …
…requiring. closes #3558
1de589c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment