New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests to make sure that bundling works as well as require in node.js #3558

Closed
wants to merge 4 commits into
from

Conversation

Projects
None yet
3 participants
@gkatsev
Member

gkatsev commented Aug 22, 2016

Description

Fixes #3541

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Unit Tests updated or fixed
  • Reviewed by Core Contributors
@gkatsev

This comment has been minimized.

Show comment
Hide comment
@gkatsev

gkatsev Aug 22, 2016

Member

@ljharb if you have any input on this as well, would be appreciated.

Member

gkatsev commented Aug 22, 2016

@ljharb if you have any input on this as well, would be appreciated.

@ljharb

This comment has been minimized.

Show comment
Hide comment
@ljharb

ljharb Aug 22, 2016

Contributor

LGTM

Contributor

ljharb commented Aug 22, 2016

LGTM

@misteroneill

This comment has been minimized.

Show comment
Hide comment
@misteroneill

misteroneill Aug 23, 2016

Member

LGTM

We should definitely do something like this in the plugin generator.

Member

misteroneill commented Aug 23, 2016

LGTM

We should definitely do something like this in the plugin generator.

@gkatsev gkatsev closed this in c154518 Aug 24, 2016

@gkatsev gkatsev deleted the require-tests branch Aug 24, 2016

helenjer pushed a commit to helenjer/video.js that referenced this pull request Sep 6, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment