Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new v6 buttons to the adaptive stylesheet #4371

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
3 participants
@hartman
Copy link
Contributor

commented May 19, 2017

The controlbar elements .vjs-subs-caps-button and .vjs-volume-panel
are new in v6, but had not been added to this CSS file.

Description

Please describe the change as necessary.
If it's a feature or enhancement please be as detailed as possible.
If it's a bug fix, please link the issue that it fixes or describe the bug in as much detail.

Specific Changes proposed

Please list the specific changes involved in this pull request.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors
Add new v6 buttons to the adaptive stylesheet
The controlbar elements .vjs-subs-caps-button and .vjs-volume-panel
are new in v6, but had not been added to this CSS file.
@gkatsev

This comment has been minimized.

Copy link
Member

commented May 25, 2017

the volume-control is still available. The volume-menu-button was just swapped out for the volume-panel. Should we have all in there then?

@gkatsev
Copy link
Member

left a comment

Thanks @hartman, sorry it took so long to review.
A couple of comment, though.

@@ -7,9 +7,9 @@

.vjs-current-time, .vjs-time-divider, .vjs-duration, .vjs-remaining-time,
.vjs-playback-rate, .vjs-progress-control,
.vjs-mute-control, .vjs-volume-control,

This comment has been minimized.

Copy link
@gkatsev

gkatsev Jun 26, 2017

Member

we probably still want to keep vjs-volume-control in here and add vjs-volume-panel since it's possible to add the volume control to the control bar separately as well.

@@ -34,7 +34,7 @@
.video-js.vjs-layout-small:not(.vjs-fullscreen) {
.vjs-current-time, .vjs-time-divider, .vjs-duration, .vjs-remaining-time,
.vjs-playback-rate,
.vjs-mute-control, .vjs-volume-control,
.vjs-mute-control, .vjs-volume-panel,

This comment has been minimized.

Copy link
@gkatsev

gkatsev Jun 26, 2017

Member

according to the comment above, vjs-volume-panel shouldn't be here because it's a replacement for the volume menu button.

@stale

This comment has been minimized.

Copy link

commented Jul 3, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the outdated label Jul 3, 2018

@gkatsev gkatsev added pinned and removed outdated labels Jul 3, 2018

gkatsev added a commit that referenced this pull request Oct 10, 2018

feat: Add breakpoints option to support toggling classes based on pla…
…yer width. (#5471)

This adds a breakpoints option. By default, this option is false meaning this is an opt-in feature.

When passing true, it will use a default set of breakpoints. Or custom breakpoints can be passed if users do not like our breakpoints (or previously-existing style decisions).

- Add breakpoints option.
- Adds some new (currently unused) classes: vjs-layout-medium, vjs-layout-large, vjs-layout-x-large, and vjs-layout-huge.
- Add updateCurrentBreakpoint and currentBreakpoint methods to the player.
- Update css/components/_adaptive.scss
- Add sandbox/responsive.html.example

Closes #4371

gkatsev added a commit that referenced this pull request Oct 31, 2018

feat: Add breakpoints option to support toggling classes based on pla…
…yer width. (#5471)

This adds a breakpoints option. By default, this option is false meaning this is an opt-in feature.

When passing true, it will use a default set of breakpoints. Or custom breakpoints can be passed if users do not like our breakpoints (or previously-existing style decisions).

- Add breakpoints option.
- Adds some new (currently unused) classes: vjs-layout-medium, vjs-layout-large, vjs-layout-x-large, and vjs-layout-huge.
- Add updateCurrentBreakpoint and currentBreakpoint methods to the player.
- Update css/components/_adaptive.scss
- Add sandbox/responsive.html.example

Closes #4371

gkatsev added a commit that referenced this pull request Oct 31, 2018

feat: Add breakpoints option to support toggling classes based on pla…
…yer width. (#5471)

This adds a breakpoints option. By default, this option is false meaning this is an opt-in feature.

When passing true, it will use a default set of breakpoints. Or custom breakpoints can be passed if users do not like our breakpoints (or previously-existing style decisions).

- Add breakpoints option.
- Adds some new (currently unused) classes: vjs-layout-medium, vjs-layout-large, vjs-layout-x-large, and vjs-layout-huge.
- Add updateCurrentBreakpoint and currentBreakpoint methods to the player.
- Update css/components/_adaptive.scss
- Add sandbox/responsive.html.example

Closes #4371
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.