New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GA note to primary readme #4481

Merged
merged 5 commits into from Oct 31, 2017

Conversation

Projects
None yet
5 participants
@mmcc
Member

mmcc commented Jul 12, 2017

We already added a similar note to the getting started guide on the website, so it should probably be here too for the folks that don't make it off Github.

Show outdated Hide outdated README.md
@mmcc

This comment has been minimized.

Show comment
Hide comment
@mmcc

mmcc Aug 17, 2017

Member

@mister-ben @OwenEdwards Made the update to be more explicit, let me know what you all think.

Member

mmcc commented Aug 17, 2017

@mister-ben @OwenEdwards Made the update to be more explicit, let me know what you all think.

@OwenEdwards

Suggest explicitly including other ways to not include the Google Analytics tracking in a website in the primary README.

Show outdated Hide outdated README.md
@mister-ben

This comment has been minimized.

Show comment
Hide comment
@mister-ben

mister-ben Aug 21, 2017

Contributor

"CDN hosted" could be more specific to make it clear it's the version hosted on vjs.zencdn.net only, and not anything you'd find on unpkg, cdnjs etc.

Contributor

mister-ben commented Aug 21, 2017

"CDN hosted" could be more specific to make it clear it's the version hosted on vjs.zencdn.net only, and not anything you'd find on unpkg, cdnjs etc.

@gkatsev

This comment has been minimized.

Show comment
Hide comment
@gkatsev

gkatsev Oct 25, 2017

Member

@mmcc @mister-ben @OwenEdwards I made a PR against this branch with changes: mmcc#10

Member

gkatsev commented Oct 25, 2017

@mmcc @mister-ben @OwenEdwards I made a PR against this branch with changes: mmcc#10

@gkatsev

This comment has been minimized.

Show comment
Hide comment
@gkatsev

gkatsev Oct 25, 2017

Member

And it's been merged here.

Member

gkatsev commented Oct 25, 2017

And it's been merged here.

@gkatsev gkatsev merged commit e2af322 into videojs:master Oct 31, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@gkatsev

This comment has been minimized.

Show comment
Hide comment
@gkatsev

gkatsev Oct 31, 2017

Member

Merged this. If we think there are other additions, please make a PR or post here and we can update it again.

Member

gkatsev commented Oct 31, 2017

Merged this. If we think there are other additions, please make a PR or post here and we can update it again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment