New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add package-lock.json file. #4641

Merged
merged 1 commit into from Oct 19, 2017

Conversation

Projects
None yet
3 participants
@misteroneill
Member

misteroneill commented Oct 3, 2017

Adds the package-lock.json file for npm 5.

Requirements Checklist

  • Feature implemented / Bug fixed
  • Reviewed by Two Core Contributors
@thijstriemstra

This comment has been minimized.

Show comment
Hide comment
@thijstriemstra

thijstriemstra Oct 13, 2017

Contributor

What's the purpose of this file?

Contributor

thijstriemstra commented Oct 13, 2017

What's the purpose of this file?

@gkatsev

This comment has been minimized.

Show comment
Hide comment
@gkatsev

gkatsev Oct 13, 2017

Member

It's to make the development more reproducible once we move over to use npm5: https://docs.npmjs.com/files/package-locks

Member

gkatsev commented Oct 13, 2017

It's to make the development more reproducible once we move over to use npm5: https://docs.npmjs.com/files/package-locks

@thijstriemstra

This comment has been minimized.

Show comment
Hide comment
@thijstriemstra

thijstriemstra Oct 13, 2017

Contributor

Thanks for the info @gkatsev. Looks very complex, SVN like (e.g. .svn dirs), too bad.

Contributor

thijstriemstra commented Oct 13, 2017

Thanks for the info @gkatsev. Looks very complex, SVN like (e.g. .svn dirs), too bad.

@gkatsev

This comment has been minimized.

Show comment
Hide comment
@gkatsev

gkatsev Oct 13, 2017

Member

@thijstriemstra yw, thanks for looking at PR!
Hopefully, we won't really need to look at this file ever really. We just wanted to get this added separately/explicitly.

Member

gkatsev commented Oct 13, 2017

@thijstriemstra yw, thanks for looking at PR!
Hopefully, we won't really need to look at this file ever really. We just wanted to get this added separately/explicitly.

@thijstriemstra

This comment has been minimized.

Show comment
Hide comment
@thijstriemstra

thijstriemstra Oct 13, 2017

Contributor

pro-tip: don't take a look at the diff. github is right, it's too big ;)

Contributor

thijstriemstra commented Oct 13, 2017

pro-tip: don't take a look at the diff. github is right, it's too big ;)

@gkatsev gkatsev merged commit ec5b603 into videojs:master Oct 19, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@misteroneill misteroneill deleted the misteroneill:pkg-lock branch Oct 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment