New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: set the seek bar to 100% on ended #4648

Merged
merged 3 commits into from Oct 31, 2017

Conversation

Projects
None yet
3 participants
@BrandonOCasey
Contributor

BrandonOCasey commented Oct 5, 2017

Description

As with the other prs that just went in, we want to make it seem like a video has ended from a user perspective, even if internally e know something is off. (currentTime !== duration, but the video has ended).

Specific Changes proposed

A small refactor of seekBar to allow this

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chome, Firefox, IE)
@misteroneill

This comment has been minimized.

Show comment
Hide comment
@misteroneill

misteroneill Oct 5, 2017

Member

I'd like to do some testing, but overall this looks solid.

Member

misteroneill commented Oct 5, 2017

I'd like to do some testing, but overall this looks solid.

@gkatsev

A minor comments, LGTM otherwise.

// Allows for smooth scrubbing, when player can't keep up.
const time = (this.player_.scrubbing()) ?
getCurrentTime_() {
return (this.player_.scrubbing()) ?
this.player_.getCache().currentTime :

This comment has been minimized.

@gkatsev

gkatsev Oct 19, 2017

Member

huh, we have a getCache() method?

@gkatsev

gkatsev Oct 19, 2017

Member

huh, we have a getCache() method?

This comment has been minimized.

@BrandonOCasey

BrandonOCasey Oct 20, 2017

Contributor

yeah haha

@BrandonOCasey

BrandonOCasey Oct 20, 2017

Contributor

yeah haha

Show outdated Hide outdated src/js/control-bar/progress-control/seek-bar.js

BrandonOCasey added some commits Oct 20, 2017

@gkatsev gkatsev merged commit 5e9655f into master Oct 31, 2017

3 checks passed

continuous-integration/codeship Build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@gkatsev gkatsev deleted the feat/100%-ended branch Oct 31, 2017

@gkatsev gkatsev referenced this pull request Oct 31, 2017

Merged

improvement: PlayProgressBar Smooth Transition #4591

3 of 7 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment