New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make sure we remove vjs-ended from the play toggle in all appropriate cases. #4661

Merged
merged 1 commit into from Oct 13, 2017

Conversation

Projects
None yet
4 participants
@misteroneill
Member

misteroneill commented Oct 12, 2017

There are cases where we might not see a seeked event when replaying a video. This will make this code more reliable.

Requirements Checklist

  • Feature implemented / Bug fixed
  • Reviewed by Two Core Contributors
@misteroneill

This comment has been minimized.

Show comment
Hide comment
@misteroneill

misteroneill Oct 12, 2017

Member

Removed the one comment because it was kind of redundant.

Member

misteroneill commented Oct 12, 2017

Removed the one comment because it was kind of redundant.

@gkatsev gkatsev merged commit 0287f6e into master Oct 13, 2017

3 checks passed

continuous-integration/codeship Build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@gkatsev gkatsev deleted the fix-play-toggle branch Oct 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment