fix: Make sure we remove vjs-ended from the play toggle in all appropriate cases. #4661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonocasey
approved these changes
Oct 12, 2017
gkatsev
reviewed
Oct 12, 2017
src/js/control-bar/play-toggle.js
Outdated
| @@ -101,6 +99,7 @@ class PlayToggle extends Button { | |||
| * @listens Player#pause | |||
| */ | |||
| handlePause(event) { | |||
| this.removeClass('vjs-ended'); | |||
There was a problem hiding this comment.
not sure we want this. If you're ended and the player is told to pause, it should look the same.
There was a problem hiding this comment.
agreed, this ended thing is starting to look messy (see extra releases just to fix things related to this). +1 for not making the play-toggle more complex (which trickles down to plugins).
misteroneill
force-pushed
the
fix-play-toggle
branch
from
86dcf94
to
15926ca
Compare
|
Removed the one comment because it was kind of redundant. |
gkatsev
approved these changes
Oct 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are cases where we might not see a
seekedevent when replaying a video. This will make this code more reliable.Requirements Checklist