New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor player.hasStarted() #4680

Merged
merged 4 commits into from Oct 31, 2017

Conversation

Projects
None yet
3 participants
@kocoten1992
Contributor

kocoten1992 commented Oct 22, 2017

update doc on hasStarted()

I feel 'request' are more suitable than hasStarted (as a variable) because when I do "if (request === undefined)", it mean if you don't have any request, then we just return current status, it a bit more clear

Requirements Checklist

  • Docs/guides updated

kocoten1992 added some commits Oct 22, 2017

refactor player.hasStarted()
update doc on hasStarted()

I feel 'request' are more suitable than hasStarted (variable) because when I do "if (request === undefined)", it mean if you don't have any request, then we just return current status, it a bit more clear
@kocoten1992

This comment has been minimized.

Show comment
Hide comment
@kocoten1992

kocoten1992 Oct 22, 2017

Contributor

Hi @gkatsev , does this style of writing clearer than the previous one.

Cause I'm running through the source and see a lot of js write at old style, if this pull request accepted, I might refactor some more ?

Contributor

kocoten1992 commented Oct 22, 2017

Hi @gkatsev , does this style of writing clearer than the previous one.

Cause I'm running through the source and see a lot of js write at old style, if this pull request accepted, I might refactor some more ?

@gkatsev

Thanks @kocoten1992. We do have a lot of code that we just ported over and didn't refactor. Only had a couple of small comments on this, overall it's a good change.

Show outdated Hide outdated src/js/player.js
Show outdated Hide outdated src/js/player.js
Show outdated Hide outdated src/js/player.js
@gkatsev

Thanks @kocoten1992! Looking forward to more PRs :D

@misteroneill

What he said. Thank you!

@gkatsev gkatsev added the confirmed label Oct 24, 2017

@gkatsev gkatsev merged commit cde8335 into videojs:master Oct 31, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment