New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore: get rid of redundant test logging #4682

Merged
merged 1 commit into from Oct 23, 2017

Conversation

Projects
None yet
2 participants
@BrandonOCasey
Contributor

BrandonOCasey commented Oct 23, 2017

Description

Currently you have to specify a second param in addRemoteTextTrack so that it does not log. This causes a few lines to log for every browser, which can make things a bit confusing.

@gkatsev

LGTM.
Should be merged as test, not ignore.

@BrandonOCasey BrandonOCasey merged commit 983a573 into master Oct 23, 2017

0 of 3 checks passed

continuous-integration/codeship Build in progress
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details

@gkatsev gkatsev deleted the ignore/test-logging branch Oct 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment